Skip to content

Conversation

VeraZab
Copy link
Contributor

@VeraZab VeraZab commented Jan 3, 2019

part of #803

  • Axes Panel
  • Color Bars Panel

@nicolaskruchten nicolaskruchten mentioned this pull request Jan 3, 2019
6 tasks
@VeraZab VeraZab force-pushed the dtick branch 3 times, most recently from 3361692 to 4bf4821 Compare January 3, 2019 18:45
@VeraZab
Copy link
Contributor Author

VeraZab commented Jan 3, 2019

@nicolaskruchten ready for review..
rearanging my commit order didn't work when force pushing.. I guess github UI orders them by time of commit..this is the order I wanted to have:

pick 811a316 create DTicksInterval to keep visibility rules
pick 97a5958 AxisInterval adjustments for Axes Panel
pick 4bf4821 Add AxisInterval to ColorBars

@nicolaskruchten
Copy link
Contributor

Looks great!

Some oddities though, when switching into 'custom' spacing mode and then switching from days to months ... Can we do something smart with the initial value here or... ?

editor

@nicolaskruchten
Copy link
Contributor

I think the behaviour above is related to https://github.com/plotly/streambed/issues/11864

@VeraZab
Copy link
Contributor Author

VeraZab commented Jan 3, 2019

I can reproduce the off default value behavior in this codepen: https://codepen.io/veraz/pen/VqQQGj?editors=0010, issue opened in plotly.js here: plotly/plotly.js#3395

@nicolaskruchten
Copy link
Contributor

OK, 💃

@VeraZab VeraZab merged commit 05f31dd into master Jan 4, 2019
@VeraZab VeraZab deleted the dtick branch January 4, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants